]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
networkAgent: Add missing Uint8Array => string conversion
authorFlorian Müllner <fmuellner@gnome.org>
Thu, 13 Aug 2020 21:37:31 +0000 (23:37 +0200)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Thu, 13 Aug 2020 23:00:21 +0000 (23:00 +0000)
When promisifying async operations in commit 764527c8c, the
finish function for read_line_async() was sneakily changed from
read_line_finish_utf8() to read_line_finish().

That is, the call returns a Uint8Array now that requires an
explicit conversion to string.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1407

js/ui/components/networkAgent.js

index 32ec1da8522658f24c40ebe0aedf11b2a7466146..29565d214f22b08581369a9c767e8aaca3004526 100644 (file)
@@ -494,7 +494,7 @@ var VPNRequestHandler = class {
             return;
         }
 
-        this._vpnChildProcessLineOldStyle(line);
+        this._vpnChildProcessLineOldStyle(ByteArray.toString(line));
 
         // try to read more!
         this._readStdoutOldStyle();